Fix TreeDataGridPresenterBase Replace Regression #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated this to resolve conflicts. I've also added a minimal reproducible example to #265. If anyone gets time to take a look, it would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #265. The more efficient use of
ItemsReplacedis kept when the old and new items have the same length. Otherwise, the previous behavior is used.Note that AvaloniaUI/Avalonia#13795 made the same change to
VirtualizingStackPanelthat was made toTreeDataGridPresenterBasewhich caused the issue. I haven't used theVirtualizingStackPanelbefore, so I can't test if it has the same issue.