Correctly handle recycling following changes to Items when the TDG is not attached to the VisualTree #359
+100
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message from nuke was:
```
[WRN] : Solution /home/vsts/work/1/s/Avalonia.Controls.TreeDataGrid.sln has active build configurations for the build project.
Either enable SuppressBuildProjectCheck on Build.Solution or remove the following entries from the solution file:
- {D45C7B46-A12C-4412-8397-B51B75A09999}.Debug|Any CPU.Build.0 = Debug|Any CPU
- {D45C7B46-A12C-4412-8397-B51B75A09999}.Release|Any CPU.Build.0 = Release|Any CPU
```
Not sure why this has started happening now, but doing what it says.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user places the TDG inside a tab control and does the following:
the user will see many rows that are duplicated… i.e. the recycling mechanism messed up and assigned the same model to multiple rows.
This PR fixes the issue by recycling all elements when a TdgPresenter is detached from the VisualTree.
(the same logic is already implemented from detaching from the logical tree, and in recent memory leak fixes we unsubscribe from item changes during the detached phase, meaning we now need to handle this on visual tree detach also)