Fixes LineHeight calculated for TextLines that only contain an embedded control run #20424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gillibald
added
bug
regression
backport-candidate-11.3.x
|
You can test this PR using the following package version. |
Member
|
The changes mean that the paragraph's ascent/descent/linegap properties won't be applied anymore even to normal text runs. Code: <TextBlock FontFamily="/Assets/#Noto Sans Arabic" TextWrapping="Wrap" Width="200">
<Run Text="رقم التسلسل" />
<Run Text="Serial Number Serial Number Serial Number" FontFamily="Arial" />
</TextBlock>Font: Noto Sans Arabic Before (master): After (PR): |
MrJul
requested changes
Jan 7, 2026
Member
MrJul
left a comment
MrJul
left a comment
There was a problem hiding this comment.
This breaks some other scenarios, see comment above.
Contributor
Author
|
Paragraph properties are inherited if a TextRun does not override them. If all runs are fallback runs we no longer apply the "wrong" metrics. Do we want that? |
Contributor
Author
|
This needs more discussion about how we want to handle text metrics for the line height calculation |
MrJul
removed
the
backport-candidate-11.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The TextLineImpl is currently using the default TextMetrics to calculate the initial descent, ascent, and line gap. This causes an issue with TextLines that only contain an EmbeddedControlRun with no descent, and therefore, the final descent should be zero. This PR ensures the descent is zero instead of the default value of the currently active font.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes: #20406