Fixed outdated font binding examples.#719
Merged
timunie merged 2 commits intoAvaloniaUI:mainfrom Sep 26, 2025
Merged
Conversation
In the original example: The `GetInstalledFontFamilyNames` method has been removed. The `Items` property of `ComboBox` has been set to read-only and cannot be directly assigned. Therefore, I have rewritten this example.
timunie
suggested changes
Sep 16, 2025
Contributor
timunie
left a comment
timunie
left a comment
There was a problem hiding this comment.
I feel like the Window-tag around the sample is not needed. In case you have a mobile App for example there is even no window, so for newbies it can be also missleading. Otherwise the changes are looking good to me.
Remove the Window-tag that should not appear in the case.
Contributor
Author
|
I was wondering about this earlier, thanks for providing the reason. The Window-tag has now been deleted. I'm not sure if I should directly add a commit? Or should I create a new merge request to combine both changes in a single commit? |
Contributor
|
Yeah, you can simply commit and the PR will be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original example:
The
GetInstalledFontFamilyNamesmethod has been removed.The
Itemsproperty ofComboBoxhas been set to read-only and cannot be directly assigned.Therefore, I have rewritten this example.