Open
Conversation
Made AVCam alert optional, added no permissions state to camera view
Swift4 merged
migrate to swift5
|
@Awalz any plans on supporting Swift 5? Would love to see this merged |
PoeticPete
reviewed
Apr 22, 2021
| NotificationCenter.default.removeObserver(self) | ||
| sessionRunning = false | ||
| // If session is running, stop the session | ||
| // if self.isSessionRunning == true { |
There was a problem hiding this comment.
I think we still want the session to stop running when the vc disappears
Author
There was a problem hiding this comment.
Ah, yes you're right. This edit may have been too coupled to my use case.
Author
|
It's been a couple years since I last worked on anything iOS. I probably won't have time to clean up this PR's conflicts nor respond to feedback, but hopefully this PR helps someone else bring SwitftyCam up to Swift5 support. |
|
@Awalz can you merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working and compiling using Swift 5. If you are interested in merging this to master, I can fix the conflicts. Thanks,