Conversation
JonET
force-pushed
the
feature-smilie-picker
branch
from
06b1d5c to
fac63df
Compare
- Match local development environment - Update to actions/checkout@v4 with recursive submodules - Use iPhone 16 simulator with iOS 18.0
Added SmiliePickerView, SmilieData, SmilieGridItem, SmilieSearchViewModel, and AnimatedImageView to the Awful target to fix CI compilation errors
nolanw
left a comment
nolanw
left a comment
There was a problem hiding this comment.
Nice!!
I don't think anything I commented on is a dealbreaker, so take what you like and leave what you don't.
|
Also ci has been broken for ages so by all means check if the failure is from new code, but otherwise it might be ignorable :/ keep meaning to ditch useless tests and then finally fix it. |
Thanks. It runs locally, so I'm going to dig a little bit more to see if the test step can be fixed. |
Set SWIFT_STRICT_CONCURRENCY=minimal to match local development environment
|
@nolanw I think I've got all of the issues resolved. |
nolanw
left a comment
nolanw
left a comment
There was a problem hiding this comment.
Thanks for all that! One more thing and then good to merge imo
|
ship it! |
2 participants
This implements a new smilie picker with search capabilities. Replacing the functionality of the smilie keyboard. You can still access the existing smilie keyboard in Settings. Supports both dark and light themes, and seems to work on iPad in the simulator just fine.
Video of the feature in action.
https://www.youtube.com/watch?v=uJPIMOOZC64