Fix crash when pasting images in post composer #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app would crash with 'attempt to create backwards NSTextRange from 1 to 0' when pasting images into a post. This was caused by the text system trying to query text ranges while they were being modified. Fixed by: - Storing the original selected range before text storage modifications - Completing all text storage edits before updating the selection - Deferring selection updates to the next run loop cycle to avoid conflicts with the text system's internal state - Adding bounds checking to ensure valid cursor positions This prevents race conditions between our selection updates and the text system's attribute queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app would crash with 'attempt to create backwards NSTextRange from 1 to 0' when pasting images into a post. This was caused by the text system trying to query text ranges while they were being modified.
Fixed by:
This prevents race conditions between our selection updates and the text system's attribute queries.