-
Notifications
You must be signed in to change notification settings - Fork 275
Change namespace and add adapter #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5c80ed
Change namespace and add adapter
gaffney2010 86f75bd
Change namespace back
gaffney2010 3b4b642
Add adapter tests
gaffney2010 ff277de
Add deprecation warnings
gaffney2010 cebf117
Add files that have been moved back to their namespace. Were previou…
gaffney2010 6ba07b8
Mildly change the docs for new naming.
gaffney2010 065d166
Add more files that have been moved back to their namespace. Were pr…
gaffney2010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,28 @@ | ||
DEFAULT_TURNS = 200 | ||
|
||
# The order of imports matters! | ||
from axelrod.ipd import graph | ||
from axelrod.ipd.action import Action | ||
from axelrod.ipd.random_ import random_choice, random_flip, seed, Pdf | ||
from axelrod.ipd import eigen | ||
from axelrod.ipd.plot import Plot | ||
from axelrod.ipd.history import History, LimitedHistory | ||
from axelrod.player import BasePlayer | ||
from axelrod.ipd.player import IpdPlayer | ||
from axelrod.ipd.classifier import Classifiers | ||
from axelrod.ipd.evolvable_player import EvolvablePlayer | ||
from axelrod.game import BaseGame | ||
from axelrod.ipd.game import IpdGame, DefaultGame | ||
from axelrod.ipd.moran import MoranProcess, ApproximateMoranProcess | ||
from axelrod.ipd.strategies import * | ||
from axelrod.ipd.match_generator import * | ||
from axelrod.ipd.tournament import IpdTournament | ||
from axelrod.ipd.ecosystem import Ecosystem | ||
from axelrod.ipd.match import IpdMatch | ||
from axelrod.ipd.result_set import ResultSet | ||
from axelrod.ipd.deterministic_cache import DeterministicCache | ||
from axelrod.ipd import fingerprint | ||
from axelrod.ipd.fingerprint import AshlockFingerprint, TransitiveFingerprint | ||
from axelrod.ipd import interaction_utils | ||
from axelrod.ipd.mock_player import MockPlayer | ||
from axelrod.version import __version__ | ||
from axelrod.load_data_ import load_pso_tables, load_weights | ||
from axelrod import graph | ||
from axelrod.action import Action | ||
from axelrod.random_ import random_choice, random_flip, seed, Pdf | ||
from axelrod.plot import Plot | ||
from axelrod.game import DefaultGame, Game | ||
from axelrod.history import History, LimitedHistory | ||
from axelrod.player import Player | ||
from axelrod.classifier import Classifiers | ||
from axelrod.evolvable_player import EvolvablePlayer | ||
from axelrod.mock_player import MockPlayer | ||
from axelrod.match import Match | ||
from axelrod.moran import MoranProcess, ApproximateMoranProcess | ||
from axelrod.strategies import * | ||
from axelrod.deterministic_cache import DeterministicCache | ||
from axelrod.match_generator import * | ||
from axelrod.tournament import Tournament | ||
from axelrod.result_set import ResultSet | ||
from axelrod.ecosystem import Ecosystem | ||
from axelrod.fingerprint import AshlockFingerprint, TransitiveFingerprint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...od/compute_finite_state_machine_memory.py → ...pd/compute_finite_state_machine_memory.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the idea be (for now from the pov of keeping the current API) to change this to:
Or perhaps it would be nicer to have:
as
As the namespace takes care of the tournament? So theoretically we would also have:
At some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then similarly for the
IpdMatch
? Perhaps just haveaxelrod.ipd.match.Match
? Which makes things easier now but I believe also later as when we have multiple game types aMatch
is always the name of the object needed and the namespace takes care of behaviour?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need a new Match for each game -- maybe a generic Match class could work? Same for Tournaments -- maybe these classes don't need to know about the Game and the Players, they just need to be handed Players and a compatible Game.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great!