Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the NoctisUI codebase with significant formatting and structural changes, including the introduction of a custom Color class to replace java.awt.Color, a new UIBaseComponent base class for UI components, and extensive code style modifications.
Key changes:
- Introduces custom
Colorclass with utilities for color manipulation (HSB conversion, interpolation, brightness adjustment) - Creates
UIBaseComponentabstract class to provide shared properties for UI components - Applies controversial brace-on-new-line formatting throughout the codebase
- Removes blur functionality (
BlurProgramclass deleted, blur-related code removed)
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 27 comments.
Show a summary per file
| File | Description |
|---|---|
Color.java |
New custom color class with RGBA support and HSB conversion utilities |
MathUtils.java |
Formatting changes to brace placement |
UIBaseComponent.java |
New base class providing common UI component properties |
NotificationType.java |
Import change from java.awt.Color to custom Color, formatting updates |
NotificationManager.java |
Updated to use custom Color class, extensive formatting changes |
Notification.java |
Import updates and multiple-statements-per-line formatting |
TextInput.java |
Extends UIBaseComponent, uses custom Color and MathUtils, severe readability issues |
DivComponent.java |
Extends UIBaseComponent, refactored API, contains coordinate transformation bug |
Button.java |
Extends UIBaseComponent, simplified API, removed blur support |
TextComponent.java |
Extends UIBaseComponent, uses custom Color |
ImageComponent.java |
Extends UIBaseComponent with type changes from int to float |
FontAtlas.java |
Updated to use custom Color, formatting changes |
Shaders.java |
Removed blur shader support |
Render2DEngine.java |
Removed all blur-related methods |
BlurProgram.java |
Completely deleted |
Comments suppressed due to low confidence (4)
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:70
- This method overrides UIBaseComponent.setVisible; it is advisable to add an Override annotation.
@Setter
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:69
- This method overrides UIBaseComponent.isVisible; it is advisable to add an Override annotation.
@Getter
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:67
- This method overrides UIBaseComponent.setEnabled; it is advisable to add an Override annotation.
@Setter
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:66
- This method overrides UIBaseComponent.isEnabled; it is advisable to add an Override annotation.
@Getter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/client/java/fr/libnaus/noctisui/client/component/system/NotificationType.java
Outdated
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/system/Notification.java
Outdated
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/system/Notification.java
Outdated
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/DivComponent.java
Outdated
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java
Outdated
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/system/Notification.java
Show resolved
Hide resolved
src/client/java/fr/libnaus/noctisui/client/component/system/NotificationManager.java
Show resolved
Hide resolved
…tificationType.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tification.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tification.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tificationManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tInput.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tInput.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tificationManager.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot ouvre une pullrequest ou tu fait la documentation dans le /docs/ en .md, quelque chose de bien fait et en anglais |
No description provided.