Skip to content

Refonte du code#55

Merged
AxenoDev merged 11 commits intomasterfrom
refactor/cleanup-code
Nov 8, 2025
Merged

Refonte du code#55
AxenoDev merged 11 commits intomasterfrom
refactor/cleanup-code

Conversation

@AxenoDev
Copy link
Copy Markdown
Owner

@AxenoDev AxenoDev commented Nov 8, 2025

No description provided.

@AxenoDev AxenoDev added this to the 1.0.0-beta-6 milestone Nov 8, 2025
@AxenoDev AxenoDev self-assigned this Nov 8, 2025
@AxenoDev AxenoDev added 🔄️ Changement Changement d'une feature ou autre 🆙 Amélioration Amélioration sur une feature ou autre labels Nov 8, 2025
@AxenoDev AxenoDev linked an issue Nov 8, 2025 that may be closed by this pull request
@AxenoDev AxenoDev requested a review from Copilot November 8, 2025 15:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the NoctisUI codebase with significant formatting and structural changes, including the introduction of a custom Color class to replace java.awt.Color, a new UIBaseComponent base class for UI components, and extensive code style modifications.

Key changes:

  • Introduces custom Color class with utilities for color manipulation (HSB conversion, interpolation, brightness adjustment)
  • Creates UIBaseComponent abstract class to provide shared properties for UI components
  • Applies controversial brace-on-new-line formatting throughout the codebase
  • Removes blur functionality (BlurProgram class deleted, blur-related code removed)

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 27 comments.

Show a summary per file
File Description
Color.java New custom color class with RGBA support and HSB conversion utilities
MathUtils.java Formatting changes to brace placement
UIBaseComponent.java New base class providing common UI component properties
NotificationType.java Import change from java.awt.Color to custom Color, formatting updates
NotificationManager.java Updated to use custom Color class, extensive formatting changes
Notification.java Import updates and multiple-statements-per-line formatting
TextInput.java Extends UIBaseComponent, uses custom Color and MathUtils, severe readability issues
DivComponent.java Extends UIBaseComponent, refactored API, contains coordinate transformation bug
Button.java Extends UIBaseComponent, simplified API, removed blur support
TextComponent.java Extends UIBaseComponent, uses custom Color
ImageComponent.java Extends UIBaseComponent with type changes from int to float
FontAtlas.java Updated to use custom Color, formatting changes
Shaders.java Removed blur shader support
Render2DEngine.java Removed all blur-related methods
BlurProgram.java Completely deleted
Comments suppressed due to low confidence (4)

src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:70

    @Setter

src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:69

    @Getter

src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:67

    @Setter

src/client/java/fr/libnaus/noctisui/client/component/input/TextInput.java:66

    @Getter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

AxenoDev and others added 9 commits November 8, 2025 17:06
…tificationType.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tification.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tification.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ent.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tificationManager.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tInput.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tInput.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tificationManager.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI commented Nov 8, 2025

@AxenoDev I've opened a new pull request, #56, to work on those changes. Once the pull request is ready, I'll request review from you.

@AxenoDev
Copy link
Copy Markdown
Owner Author

AxenoDev commented Nov 8, 2025

@copilot ouvre une pullrequest ou tu fait la documentation dans le /docs/ en .md, quelque chose de bien fait et en anglais

Copy link
Copy Markdown

Copilot AI commented Nov 8, 2025

@AxenoDev I've opened a new pull request, #57, to work on those changes. Once the pull request is ready, I'll request review from you.

@AxenoDev AxenoDev merged commit 19cc946 into master Nov 8, 2025
3 checks passed
@AxenoDev AxenoDev deleted the refactor/cleanup-code branch November 8, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆙 Amélioration Amélioration sur une feature ou autre 🔄️ Changement Changement d'une feature ou autre

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propreté du code

3 participants