Skip to content

add empty default and remove wrong example #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PatrickHuembeli merged 1 commit into from
Jan 6, 2025
Merged

add empty default and remove wrong example #4

PatrickHuembeli merged 1 commit into from
Jan 6, 2025

Conversation

@PatrickHuembeli
Copy link
Contributor

@PatrickHuembeli PatrickHuembeli commented Jan 2, 2025 •
edited
Loading

  • add a default example that just says "select a template"
  • removed the MITRE example
  • added the PAYLOAD example
  • added titles to the values in the widget for reabability
  • added the units of the values to avoid confusion (especially the FOV with radians)

jcbwndsr
jcbwndsr suggested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@jcbwndsr jcbwndsr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@PatrickHuembeli PatrickHuembeli merged commit 7c3f7f2 into main Jan 6, 2025
3 checks passed
@PatrickHuembeli PatrickHuembeli deleted the patrick/bugfix_axtract branch January 6, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jacobwindsor jacobwindsor jacobwindsor approved these changes

@jcbwndsr jcbwndsr jcbwndsr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PatrickHuembeli @jacobwindsor @jcbwndsr