Open
Conversation
Previously this could be passed to cargo after `--`, but doing so typically would not work since `cargo-acap-build` internally invokes Cargo to get the target dir. Now we explicitly parse that option and propagate it to all cargo subcommands. I also considered leaving it after `--`, infer any manifest path from those args and propagate it explicitly only for the internal cargo sub- commands. I'm honestly unsure which is better. Pros (of the current implementation): - No fragile, ad-hoc parsing of arguments. There are many ways this could go wrong. We could forget to handle both "=" and " ", we could forget to handle "--" (any --manifest-path after such an argument would probably not go to cargo). - It's clear to educated users which arguments directly affect the behavior of the `cargo-acap-*` programs. Cons: - The public interface of the programs change - Our interface requires `--manifest-path` to come before the command while `cargo` expects it after the command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this could be passed to cargo after
--, but doing so typically would not work sincecargo-acap-buildinternally invokes Cargo to get the target dir. Now we explicitly parse that option and propagate it to all cargo subcommands.I also considered leaving it after
--, infer any manifest path from those args and propagate it explicitly only for the internal cargo sub- commands. I'm honestly unsure which is better.Pros (of the current implementation):
cargo-acap-*programs.Cons:
--manifest-pathto come before the command whilecargoexpects it after the command.