Conversation
2223080 to
3251067
Compare
692c6df to
bc12bbf
Compare
ba43c61 to
42f7d43
Compare
steabert
commented
Feb 19, 2025
Member
Member
|
Format command works well for me. Also the dev enviroment still runs. So besides the issue above, LGTM. |
lekoaf
approved these changes
Feb 20, 2025
NiklasRamstrom
approved these changes
Feb 24, 2025
42f7d43 to
f50fcbb
Compare
Removes eslint and adds biome, which is a much faster linter that can handle TypeScript out of the box, and also does formatting. Removes circular dependencies related to importing elements into the route map, but also route map into elements. This caused a problem with vite's HMR depending on the exact order of the imports. The solution here is to only map routes to elements where needed (in this case only App.tsx).
f50fcbb to
4e3f33d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Removes eslint and adds biome, which is a much faster linter
that can handle TypeScript out of the box, and also does formatting.
NOTE:
FIXME(they either need a proper reason, or a fix)WANTED: