Merged
Conversation
When bringing in ONVIF Media Signing as a submodule some functions share the same name. This will cause multiple definitions if building the library with a populated submodule, like FilePlayer will. This commit prepends internal functions with "sv_" to make names unique. This only applies to function names common to ONVIF Media Signing.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
mithydolphin
previously approved these changes
Feb 27, 2025
mithydolphin
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bringing in ONVIF Media Signing as a submodule
some functions share the same name. This will cause
multiple definitions if building the library with a
populated submodule, like FilePlayer will.
This commit prepends internal functions with "sv_"
to make names unique. This only applies to function
names common to ONVIF Media Signing.