Changes the order of tests in test_checks.sh#422
Merged
bjornvolcker merged 1 commit intomasterfrom Mar 27, 2025
Merged
Conversation
Now the last test is a normal test with debugprints on. This simplifies life a little bit since one can keep using ninja and get tests run properly. Before this change, the last setup was to use the threaded plugin, which made no tests to run at all.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
mithydolphin
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the last test is a normal test with debugprints on. This
simplifies life a little bit since one can keep using ninja
and get tests run properly.
Before this change, the last setup was to use the threaded
plugin, which made no tests to run at all.