Fixes signing with partial GOPs #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality has not worked properly if BUs were split in parts or if the stream had FH or AUDs. Updates of the linked hash failed. Various tests for this has now been added. Also, a API name change from signed_viedo_set_max_signing_frames to signed_video_set_max_signing_frames. This has no impact on API breaks since it has not been used anywhere. The version is bumped to v2.3.1.
bjornvolcker
requested review from
Caroline-Holmstrom,
lusikamalo2 and
mithydolphin
as code owners
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality has not worked properly if BUs were split in
parts or if the stream had FH or AUDs. Updates of the linked
hash failed.
Various tests for this has now been added.
Also, a API name change from signed_viedo_set_max_signing_frames
to signed_video_set_max_signing_frames. This has no impact on
API breaks since it has not been used anywhere.
The version is bumped to v2.3.1.