-
Notifications
You must be signed in to change notification settings - Fork 11
feature/dcb #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/dcb #61
Changes from all commits
1f67e52
cecd0be
6abdaa7
211ad36
130e2f6
ad0b299
efd0c8b
65c20ce
d8ff95e
632aa91
3696f49
5509da4
7dd1b1b
fb1a517
f436312
16e1bcf
75a9fbd
c1977a5
440ffd5
4bc9200
89ead28
154ab5c
a701608
9ea324f
761a95a
6252ab0
d3aff5d
5ff2897
5586d55
e96b3a1
25f1f0e
883ceec
c0fa279
fd217b3
82d111c
e491826
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ message CreateContextRequest { | |
| string name = 1; | ||
| string replicationGroupName = 2; | ||
| map<string, string> meta_data = 3; | ||
| bool dcbContext = 4; | ||
| } | ||
|
|
||
| message UpdateContextPropertiesRequest { | ||
|
|
@@ -66,6 +67,7 @@ message ContextOverview { | |
| map<string, string> meta_data = 3; | ||
| int64 pendingSince = 4; | ||
| bool changePending = 5; | ||
| bool dcbContext = 6; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this mean you can update a context to become a DCB Context?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is a return message from Axon Server. Just indicating whether the context is dcb or not. |
||
| } | ||
|
|
||
| message ContextUpdate { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I am not mistaken, the "meta_data" field here is rather configuration for the context, right? Couldn't the fact that it is a DCB context be part of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MGathier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No preference here. Having it as a separate field makes it more explicite, but it may be redundant in the future.