PersistentStreams should be re-established on reconnect requests#411
Merged
smcvb merged 2 commits intoconnector-2024.2.xfrom Feb 10, 2025
Merged
PersistentStreams should be re-established on reconnect requests#411smcvb merged 2 commits intoconnector-2024.2.xfrom
smcvb merged 2 commits intoconnector-2024.2.xfrom
Conversation
By reporting an error to downstream consumers, they are notified of the fact that the disconnect didn't happen for normal reasons, and the stream should be reopened if the application wishes to continue processing events.
abuijze
changed the title
MGathier
approved these changes
Feb 6, 2025
smcvb
approved these changes
Feb 6, 2025
src/main/java/io/axoniq/axonserver/connector/event/impl/PersistentStreamImpl.java
Show resolved
Hide resolved
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By reporting an error to downstream consumers, they are notified of the fact that the disconnect didn't happen for normal reasons, and the stream should be reopened if the application wishes to continue processing events.
This avoids problems due to clients not reconnecting their persistent streams after a reconnect request from Axon Server. Applications need to be restarted to recover from this situation.
With this PR, clients are notified of the disconnect and may re-establish a connection.