Skip to content

Introducing the DcbEventChannel using the DCB API#422

Merged
m1l4n54v1c merged 44 commits intomasterfrom
feature/dcb
Jun 3, 2025
Merged

Introducing the DcbEventChannel using the DCB API#422
m1l4n54v1c merged 44 commits intomasterfrom
feature/dcb

Conversation

@m1l4n54v1c
Copy link
Contributor

@m1l4n54v1c m1l4n54v1c commented Apr 17, 2025

Axon Server DCB support

m1l4n54v1c and others added 25 commits June 20, 2023 15:39
- Removed reference to the AS jar.
Update API version to 2025.1.0-SNAPSHOT
Add mechanism to get Axon Server image. First it looks for an
environment variable. When not present, it will look for a System
property. When that's also not present, use the default Axon Server
container
@smcvb smcvb changed the title DCB API Introducing the DcbEventChannel using the DCB API May 13, 2025
@smcvb smcvb requested review from MGathier, abuijze and smcvb May 13, 2025 11:00
smcvb added 2 commits May 13, 2025 13:12
Add Axon Server image env variable
Add log statement to see it work
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the shape, although I have some change request concerning the DcbEventChannel mostly.

However, I can confirm everything works and integrates nicely with Axon Framework (as can be seen in this PR), so that's awesome!

<sonar.host.url>https://sonarcloud.io</sonar.host.url>

<axonserver.api.version>2024.1.0</axonserver.api.version>
<axonserver.api.version>2025.1.0-SNAPSHOT</axonserver.api.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make sure that we construct a pull request for this Axon Server API before we can go ahead with this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to merge it even to have a snapshot right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, exactly!

@sonarqubecloud
Copy link

Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence I'm approving this pull request.

…nnel.java

Co-authored-by: Steven van Beelen <smcvbeelen@gmail.com>
@m1l4n54v1c m1l4n54v1c marked this pull request as ready for review June 3, 2025 09:18
@m1l4n54v1c m1l4n54v1c merged commit 210ecee into master Jun 3, 2025
1 of 4 checks passed
@m1l4n54v1c m1l4n54v1c deleted the feature/dcb branch June 3, 2025 09:18
@smcvb
Copy link
Contributor

smcvb commented Jun 3, 2025

🚀

@MGathier MGathier modified the milestones: Axon Server Connector for Java 2025.0.0, Axon Server Connector for Java 2025.1.0 Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants