Open
Conversation
Updates the AxoniqConsoleRSocketClient in various ways to improve error handling: - Handle heartbeat errors, so no onErrorDropped errors occur - Replace blocking connection logic with reactive buildConnectionMono/getOrConnectRSocket, deduplicating concurrent connection attempts via a cached pending Mono - Fix heartbeat tasks never being nulled in onDisconnected, which prevented them from being rescheduled after a reconnect - Replace createRSocket (blocking .block()) with createRSocketMono - Simplify disposeCurrentConnection by removing unnecessary ReentrantLock - Add onErrorMap + doOnError in retrieveSettings for proper error logging and propagation - Distinguish "Lost connection" from "Unable to connect" based on whether a successful connection was ever established - Fix suppressConnectMessage typo (was supressConnectMessage) - Call ensureConnected immediately on start() before scheduling the maintenance task In addition, the EventSourcingConfigurerEnhancer now only is applied if the HandlerMetricRegistry is present. This removes the need to disable this enhancer in tests.
CodeDrivenMitch
requested review from
MartinPfeffer,
alex-w0,
corradom,
dilgerma and
stefanmirkovic
and removed request for
a team
CodeDrivenMitch
force-pushed
the
feature/stability-march-2026
branch
from
be61c1c to
373ab0f
Compare
CodeDrivenMitch
force-pushed
the
feature/stability-march-2026
branch
from
373ab0f to
e4e4d7f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the AxoniqConsoleRSocketClient in various ways to improve error handling:
In addition, the EventSourcingConfigurerEnhancer now only is applied if the HandlerMetricRegistry is present. This removes the need to disable this enhancer in tests.