[NEEDS #12] Refactor dependency version checking logic #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrosso
changed the title
jgrosso
force-pushed
the
refactor-version-checks
branch
5 times, most recently
from
7b1a581 to
d40146b
Compare
added 24 commits
September 5, 2017 20:43
On CI, `devDependencies` won't be installed, but Babel is required to `compile`, etc.
Tests rely on NodeGit calling the LFS filters when necessary, so we need to be using a version of NodeGit that supports this machinery in the first place.
added 21 commits
September 5, 2017 20:43
Fix tests post-rebase
`git-lfs-pull`'s manpage says "Download all Git LFS files for current ref & checkout", and I don't see any options to pull a specific branch's files. My guess is that this code was copy-and-pasted from the `fetch` command, explaining the extraneous argument. Also, this commit has test stubs for the `fetch` and `pull` commands.
jgrosso
force-pushed
the
refactor-version-checks
branch
from
d40146b to
abd2961
Compare
|
Is this rebased on #12? |
|
✅ |
|
I will review it when #12 is done then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12.
@cjhoward92 I'd appreciate a relatively thorough review of the refactor, since I'm not 100% sure how this worked originally and would appreciate a second pair of 👀.