Skip to content

Conversation

@gber
Copy link

@gber gber commented Jan 26, 2023

This seems to have been the intention in commit
d2758a8.

This seems to have been the intention in commit
d2758a8.
@ghost ghost requested review from a user and sunweaver February 1, 2023 14:13
Name=ayatana-indicator-keyboard
ObjectPath=/org/ayatana/indicator/keyboard
Position=-10
Position=110
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gber:

This would break the position on desktops. The Application Indicator has a hardcoded index of 0 in the panels, So we need a negative value to put the Keyboard Indicator to the left.


[phone]
ObjectPath=/org/ayatana/indicator/keyboard/phone
Position=1000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gber:

This override used to work on Lomiri in the past. Was there a change in the panel?

Copy link
Member

@sunweaver sunweaver Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@ghost ghost Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that Lomiri does not pretend to be a phone (any more?), it tries to be a desktop.

See discussion here: https://gitlab.com/ubports/development/core/packaging/ayatana-indicators/ayatana-indicator-keyboard/-/issues/6

And here: https://gitlab.com/ubports/development/core/packaging/ayatana-indicators/ayatana-indicator-keyboard/-/merge_requests/4#note_1254135879

OK, so according to https://gitlab.com/ubports/development/core/packaging/ayatana-indicators/ayatana-indicator-keyboard/-/issues/6 the issue should be fixed in Lomiri, rather then hacking the indicator.

If Lomiri decides to ignore the [phone] override, the least painful solution would be to reverse the indexing logic in the Lomiri panel to be consistent with existing desktop panels.

Either way, I think we should close this as it won't solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants