[WIP] [Upstream] Update translations from Crowdin#1674
Open
voodoorai2000 wants to merge 10 commits intomasterfrom
Open
[WIP] [Upstream] Update translations from Crowdin#1674voodoorai2000 wants to merge 10 commits intomasterfrom
voodoorai2000 wants to merge 10 commits intomasterfrom
Conversation
voodoorai2000
force-pushed
the
crowdin_sync
branch
2 times, most recently
from
b64f373 to
26cf4c2
Compare
These translation keys are used to set the order in which a date object will be displayed[1] They should not be translated, just reordered if it makes more sense of a given language If the expected values are not found an exception is raised: ".date.order only accepts :year, :month and :day" They should probably be somewhere else so that Crowdin translators don't feel the need to translate it. But that is a battle for another day 😌 for now simply fixing them [1] https://guides.rubyonrails.org/i18n.html#action-view-helper-methods
There seems to be some differences between the folder name and the locale name used in the files themselves. For example: the folder might have been called "de-DE", for German, but the files use one "de" And thus translations where not being displayed Using the locale key in the files and modifying the folder name if neccesary, let's see what happens in the next Crowdin pull, might need to review more thoroughly why this is happening (maybe due to custom settings in Crowdin)
Some language names seem to have disappeared and others where being displayed in the the locale with extension (`de-DE` instead of in `de`) Probably some temporary issues until Github and Crowdin are in sync 😌
voodoorai2000
force-pushed
the
crowdin_sync
branch
from
e4ed051 to
870d2d8
Compare
voodoorai2000
force-pushed
the
crowdin_sync
branch
from
870d2d8 to
1b50fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
PR: consuldemocracy#2961
PR: consuldemocracy#2974
PR: consuldemocracy#2963
Objectives
Sync translations from Crowdin
Note
@decabeza should review these translations before merging 😌
We should also add the translations from the latest Crowdin PR before review
This PR is an aggregate of the three referenced PRs. They are all related and only include translation files