Add Register page with routing and navigation button#24
Open
Bala327 wants to merge 3 commits intoAyush0316:mainfrom
Open
Add Register page with routing and navigation button#24Bala327 wants to merge 3 commits intoAyush0316:mainfrom
Bala327 wants to merge 3 commits intoAyush0316:mainfrom
Conversation
Owner
|
Author
|
sir here is my screenshot of my register component |
Author
|
kindly accept my pull request or any changes in the UI component kindly inform me. I will rectify as soon as possible |
Author
|
@Ayush0316 kindly accept my pull request or any changes in the UI component kindly inform me. I will rectify as soon as possible |
Ayush0316
reviewed
Jul 25, 2025
| const AllRoutes = () => { | ||
| return ( | ||
| <Routes> | ||
| <Route path="/register" element={<Register />} /> |
Owner
There was a problem hiding this comment.
Define this route in guest route similar to login route.
Owner
There was a problem hiding this comment.
Don't change anything in this file else it will give you merge conflicts when real landing page issue will be merged.
| <p className="text-sm text-white/70 text-center mt-4"> | ||
| Already have an account?{" "} | ||
| <span | ||
| onClick={() => navigate("/login")} |
Owner
There was a problem hiding this comment.
As it is already mentioned in contributing.md, don't use magic strings, to navigate to login page use GUEST_PATH.LOGIN.
| <div /> | ||
|
|
||
| {/* Register Link */} | ||
| <p className="mt-4 text-sm text-blue-500 cursor-pointer" onClick={() => navigate("/register")}> |
Collaborator
|
Hey @Ayush0316 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of Register page[frontend]