Conversation
|
can you please check now , i have solved this issue now |
|
Always attach a screenshot or video when working on any UI-related task. |
|
Hey @Ayush3016, I've resolved the merge conflicts and restored all landing page components.
|
|
Hi @Ayush0316 |
Ayush0316
left a comment
Ayush0316
left a comment
There was a problem hiding this comment.
UI wise, I liked your work. Just work on the changes told and you are good to go then.
If Button component isn't looking good as it is on landing page you can also pass the Custome styles. Visit localhost:5173:/dev/help/button or read ButtonComponent.readme.md.
AppUi/src/pages/landing.jsx
Outdated
| ); | ||
| }; | ||
| export default LandingPage; | ||
| import React from "react"; |
There was a problem hiding this comment.
Why are these lines still here?
| </p> | ||
| <button className="px-8 py-3 text-lg font-semibold text-white bg-gradient-to-r from-blue-500 to-purple-600 rounded-xl hover:from-blue-600 hover:to-purple-700 transition-all duration-300 shadow-lg hover:shadow-xl transform hover:-translate-y-1"> | ||
| Start Your Free Trial | ||
| </button> |
There was a problem hiding this comment.
Also, as I already announced on discord server as well, whenever you have to use button or link, don't use html button tag instead use Button component already created to maintain the consistence across the codebase.
AppUi/src/components/Button.jsx
Outdated
There was a problem hiding this comment.
Button component is already created. You are supposed to use that. Don't create your own component.
There was a problem hiding this comment.
Button component is already created. You are supposed to use that. Don't create your own component.
okay done
|
Updated UI for Button
|
Ayush0316
left a comment
Ayush0316
left a comment
There was a problem hiding this comment.
Changes which are already pointed out should not appear again in some other place. Always double check to correct it at all places. (Button and magic strings already pointed out before).
| <div className="grid grid-cols-1 md:grid-cols-2 lg:grid-cols-6 gap-8"> | ||
| {/* Brand section */} | ||
| <div className="lg:col-span-2"> | ||
| <Link to="/" className="text-3xl font-bold bg-gradient-to-r from-blue-400 to-purple-400 bg-clip-text text-transparent"> |
There was a problem hiding this comment.
As it is already mentioned in contributing.md, don't use magic strings. Use GUEST_PATH.LANDING instead.
Correct the same mistake in other files as well.
| <div className="flex justify-between items-center h-16"> | ||
| {/* Logo */} | ||
| <div className="flex-shrink-0"> | ||
| <Link to="/" className="text-2xl font-bold bg-gradient-to-r from-blue-600 to-purple-600 bg-clip-text text-transparent"> |
| <span className="relative z-10">Features</span> | ||
| <div className="absolute inset-0 bg-gradient-to-r from-blue-500/10 to-purple-500/10 rounded-xl opacity-0 group-hover:opacity-100 transition-opacity duration-300"></div> | ||
| </a> | ||
| <a href="#about" className="relative text-gray-700 hover:text-blue-600 px-4 py-2 rounded-xl text-base font-bold transition-all duration-300 hover:bg-white/20 hover:backdrop-blur-lg hover:shadow-lg group"> |
There was a problem hiding this comment.
This anchor tag is not working, missing id in about section.
| onClick={() => setIsMenuOpen(!isMenuOpen)} | ||
| className="inline-flex items-center justify-center p-2 rounded-md text-gray-700 hover:text-blue-600 hover:bg-white/20 transition-colors duration-200" | ||
| > | ||
| <svg className="h-6 w-6" stroke="currentColor" fill="none" viewBox="0 0 24 24"> |
GauriShirke12
force-pushed
the
landing-clean
branch
from
b490c03 to
26edece
Compare
…isibility -Maintained identical UI appearance with cleaner codebase
2 participants
No description provided.