Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the zones generator module from JavaScript to TypeScript, adding type safety and fixing two bugs in the process.
Changes:
- Migrated
public/modules/zones-generator.jsto TypeScript assrc/modules/zones-generator.ts - Added
Zoneinterface and proper type definitions - Updated
PackedGraphtype to includezonesandmarkersarrays - Removed old JavaScript file and corresponding script tag from index.html
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/zones-generator.ts | New TypeScript implementation of the zones generator module with proper types, class structure, and bug fixes |
| src/types/PackedGraph.ts | Added Zone type import and zones/markers properties to the PackedGraph interface |
| src/modules/index.ts | Added import for the new zones-generator TypeScript module |
| src/index.html | Removed old JavaScript script tag for zones-generator.js |
| public/modules/zones-generator.js | Deleted - migrated to TypeScript |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning