fix: include ice generation in resampling process#1302
Merged
Azgaar merged 2 commits intoAzgaar:masterfrom Feb 3, 2026
Merged
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SheepFromHeaven
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures ice (glaciers/icebergs) is generated as part of the map resampling workflow (e.g., Submap / Transform), and bumps version / cache hashes accordingly.
Changes:
- Run
Ice.generate()duringResample.process()afterFeatures.markupPack(). - Bump app version to
1.112.1. - Update
resample.jscache-busting hash insrc/index.html.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
public/modules/resample.js |
Adds ice generation into the resampling pipeline so resampled maps include ice data. |
public/versioning.js |
Updates VERSION to 1.112.1. |
src/index.html |
Updates modules/resample.js script query hash to match the new version. |
Comment on lines
+31
to
32
| Ice.generate() | ||
| createDefaultRuler(); |
There was a problem hiding this comment.
Missing trailing semicolon after Ice.generate(); the rest of this initialization sequence uses semicolons (e.g., Features.markupPack();, createDefaultRuler();). For consistency with the surrounding codebase style (see public/main.js:635 and public/modules/ui/heightmap-editor.js:262), please add ; here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Versioning