starter token checkpoint 1 and 2 #5
Conversation
| } | ||
|
|
||
| #[contract_library_function] | ||
| fn _assert_is_owner(storage: Storage, maybe_owner: AztecAddress) { |
There was a problem hiding this comment.
do we need this function defined twice in the contract? once as a library function and once as a public internal function?
If so, it would be good to explain why.
There was a problem hiding this comment.
I'd prefer just to have 1 contract in this project, rather than 1 for each checkpoint. I know this is going to be paired with the getting started tutorial, but it would be helpful to have extensive code comments throughout, so the contract by itself is still a great learning resource.
| type = "contract" | ||
|
|
||
| [dependencies] | ||
| aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } |
There was a problem hiding this comment.
Update versions to the latest
| aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v0.87.9", directory = "noir-projects/aztec-nr/aztec" } | |
| aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "v1.2.1", directory = "noir-projects/aztec-nr/aztec" } |
| @@ -0,0 +1,127 @@ | |||
| use aztec::macros::aztec; | |||
|
|
|||
There was a problem hiding this comment.
Along with specific code comments, let's add a comment block at the top explaining the educational purpose of this contract and a disclaimer about it's lack of security. Add a link to a more production ready reference (e.g. the defi wonderland standard)
No description provided.