Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
5d95bb4
Commands to copy and format generated files
aakoshh Mar 17, 2025
c1bdb0d
Set noir to the feature branch
aakoshh Mar 18, 2025
f99c869
Change C++ codegen for serde/msgpack
aakoshh Mar 18, 2025
aeefaf3
Add Witness lt
aakoshh Mar 18, 2025
07566e7
AVM transpiler Cargo.lock
aakoshh Mar 18, 2025
ab9b7ff
Merge branch 'master' into af/msgpack-codegen
aakoshh Mar 18, 2025
d356f69
Remove comments about massaging the C++ code
aakoshh Mar 19, 2025
0d9dc22
Try to deserialize as msgpack instead of binpack
aakoshh Mar 19, 2025
16124ce
Patch no longer needed with this branch
aakoshh Mar 19, 2025
0ecd8d4
Use obj.via.map
aakoshh Mar 19, 2025
ebf72f5
Check if the data can be parsed as msgpack
aakoshh Mar 19, 2025
f764a86
Disable msgpack in bb
aakoshh Mar 20, 2025
c8f6157
Fixed codegen
aakoshh Mar 21, 2025
ffdeb65
Parse program with fallback
aakoshh Mar 21, 2025
d05544d
Parse Program ignoring Brillig
aakoshh Mar 21, 2025
74880c2
Update msgpack git commit to include fix
aakoshh Mar 21, 2025
15c1c71
Deserialize WitnessStack with msgpack
aakoshh Mar 21, 2025
27349bc
Merge remote-tracking branch 'origin/master' into af/msgpack-codegen
aakoshh Mar 21, 2025
24756ff
Fix catch
aakoshh Mar 21, 2025
dfd4ee8
Remove rmp-serde from avm-transpiler dependencies
aakoshh Mar 21, 2025
c82f1b1
Fix packing newtype is_unit
aakoshh Mar 21, 2025
919ab7a
Don't use visit for unit variants
aakoshh Mar 21, 2025
a6ec247
Return optional msgpack::object to avoid double parsing
aakoshh Mar 21, 2025
8c01b30
Merge branch 'master' into af/msgpack-codegen
aakoshh Mar 21, 2025
8387aff
Revert "Return optional msgpack::object to avoid double parsing"
aakoshh Mar 21, 2025
02e3d64
Check the value of the format byte
aakoshh Mar 22, 2025
63254d3
Use lambdas to avoid double parsing
aakoshh Mar 22, 2025
4123f84
Rename to deserialize_program and deserialize_witness_stack
aakoshh Mar 22, 2025
859b4c3
Move docs into the header
aakoshh Mar 22, 2025
4c57694
Typo
aakoshh Mar 22, 2025
a095acc
Try without using MSGPACK_FIELDS
aakoshh Mar 25, 2025
0759002
Try copying into a buffer
aakoshh Mar 25, 2025
f8f0473
Revert "Try copying into a buffer"
aakoshh Mar 25, 2025
aba2338
Print field that can't be decoded
aakoshh Mar 25, 2025
5810e3b
Fix dangling obj pointer
aakoshh Mar 25, 2025
073a9d5
Revert to original msgpack-c commit version
aakoshh Mar 25, 2025
d26f4ff
Merge remote-tracking branch 'origin/master' into af/msgpack-codegen
aakoshh Mar 25, 2025
4df2bf7
Merge branch 'master' into af/msgpack-codegen
aakoshh Mar 26, 2025
d39ebcf
Add docs to warn about keeping a reference to the object_handle
aakoshh Mar 26, 2025
e62c56b
Merge branch 'master' into af/msgpack-codegen
aakoshh Mar 26, 2025
3561f81
Move deserializers into the cpp
aakoshh Mar 27, 2025
44d05fd
Use MSGPACK_FIELDS. Remove Helpers.
aakoshh Mar 27, 2025
7edaf24
Merge branch 'af/msgpack-codegen' of github.com:AztecProtocol/aztec-p…
aakoshh Mar 27, 2025
e3df1d1
Merge remote-tracking branch 'origin/master' into af/msgpack-codegen
aakoshh Mar 27, 2025
18efc8b
Merge branch 'master' into af/msgpack-codegen
aakoshh Mar 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion avm-transpiler/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions barretenberg/cpp/src/barretenberg/dsl/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ You will have to update a couple things in the new `acir.hpp`:

The same can then be done for any breaking changes introduced to `witness_stack.hpp`.

The steps described above can be executed like so:

```shell
cd noir/noir-repo && NOIR_CODEGEN_OVERWRITE=1 cargo test -p acir cpp_codegen && cd -
cp noir/noir-repo/acvm-repo/acir/codegen/acir.cpp barretenberg/cpp/src/barretenberg/dsl/acir_format/serde/acir.hpp
cp noir/noir-repo/acvm-repo/acir/codegen/witness.cpp barretenberg/cpp/src/barretenberg/dsl/acir_format/serde/witness_stack.hpp
cd barretenberg/cpp && ./format.sh changed && cd -
```

2. Full Breaking Change

This type of breaking change is rarely expected to happen, however, due to its nature there are multiple consumers of the pre-existing serialization you should be aware of if you ever need to make this change.
Expand Down
Loading
Loading