chore: remove the early returns from `complete_kernel_circuit_logic'#16563
Merged
ledwards2225 merged 5 commits intomerge-train/barretenbergfrom Aug 25, 2025
Merged
Conversation
Contributor
ledwards2225
left a comment
ledwards2225
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments
| // Perform databus consistency checks | ||
| kernel_input.kernel_return_data.assert_equal(witness_commitments.calldata); | ||
| kernel_input.app_return_data.assert_equal(witness_commitments.secondary_calldata); | ||
|
|
Contributor
There was a problem hiding this comment.
was this moved for a reason?
Contributor
Author
There was a problem hiding this comment.
I don't think it makes a difference. Just made it the same as it was in the complete_hiding_circuit_logic I think.
ledwards2225
approved these changes
Aug 25, 2025
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
…16563) Integrates the hiding kernel completion logic into the primary kernel completion method.
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
…16563) Integrates the hiding kernel completion logic into the primary kernel completion method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.
For audit-related pull requests, please use the audit PR template.