feat: merge-train/barretenberg #16631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audit part 3: merge the two verification functions into one and restructuring. * We merge the remaining two ecdsa verification functions into one. The difference between the two was that one was computing the result of ECDSA signature verification _and_ enforcing the verification to be successful, while the other was simply computing the result of ECDSA signature verification. We maintain only the function that performs the verification but doesn't enforce the verification to be successful. The rationale is that in Noir we expose signature verification, but we always receive the supposed result: `true` or `false`, and then we verify that the signature verification resulted in the expected result. * We restructure the signature verification function to make the constraints clearer. * We restructure testing to use `gtest`. This is in preparation of more thorough testing to be introduced in a follow-up PR.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Co-authored-by: ludamad <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
lucasxia01
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Closes AztecProtocol/barretenberg#1453. Shares the transcript between PG/Merge and the Decider protocols for hiding kernel soundness. We want to make sure that we can't pick the accumulator that the Decider runs on without affecting the challenges in the Decider. This mitigates an origin tag check failure as we had values from two different transcripts interacting in Decider.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore!: Merge two ecdsa verification functions (#16509)
fix(bb): grumpkin_srs_gen debug-build linking
chore: remove no-longer-used lookup grand prod delta (#16543)
feat!: share transcript between pg and decider (#16642)
END_COMMIT_OVERRIDE