chore: preliminary clean up and reorg of cycle_group#16645
Merged
ledwards2225 merged 5 commits intomerge-train/barretenbergfrom Aug 29, 2025
Merged
chore: preliminary clean up and reorg of cycle_group#16645ledwards2225 merged 5 commits intomerge-train/barretenbergfrom
ledwards2225 merged 5 commits intomerge-train/barretenbergfrom
Conversation
ledwards2225
commented
Aug 28, 2025
| return result; | ||
| } | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
Non-Ultra method deleted entirely
ledwards2225
force-pushed
the
lde/cycle-group-0
branch
from
1ef20af to
3f70426
Compare
iakovenkos
reviewed
Aug 29, 2025
| @@ -20,8 +23,6 @@ namespace bb::stdlib { | |||
|
|
|||
| template <typename Builder> | |||
| concept IsUltraArithmetic = (Builder::CIRCUIT_TYPE == CircuitType::ULTRA); | |||
Contributor
There was a problem hiding this comment.
pls remove this concept
iakovenkos
reviewed
Aug 29, 2025
| field_t borrow = lo.is_constant() ? need_borrow : field_t::from_witness(get_context(), need_borrow); | ||
|
|
||
| // directly call `create_new_range_constraint` to avoid creating an arithmetic gate | ||
| if (!lo.is_constant()) { |
Contributor
There was a problem hiding this comment.
field_t has a method split_at, I think it can be re-used here
Contributor
There was a problem hiding this comment.
oh split_at actually assumes that there's no wrapping, i.e. num_bits <= grumpkin::MAX_NO_WRAP_INTEGER_BIT_LENGTH (=252). @suyash67 shouldn't this constant actually be 253?
iakovenkos
reviewed
Aug 29, 2025
| base_point.is_point_at_infinity(), offset_generator, point_table[i]); | ||
| } | ||
| } | ||
| if constexpr (IS_ULTRA) { |
Contributor
There was a problem hiding this comment.
pls remove here and below
iakovenkos
approved these changes
Aug 29, 2025
Contributor
iakovenkos
left a comment
iakovenkos
left a comment
There was a problem hiding this comment.
LGTM! Left a couple of comments re the future work
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2025
BEGIN_COMMIT_OVERRIDE chore: preliminary clean up and reorg of cycle_group (#16645) END_COMMIT_OVERRIDE
mralj
pushed a commit
that referenced
this pull request
Oct 13, 2025
Preliminary `cycle_group` cleanup (no logic changes): - Extract subclasses `cycle_scalar`, `straus_lookup_table` and `straus_scalar_slice` and move to their own files - Remove methods marked `requires IsNotUltraArithmetic<Builder>` since no no-Ultra builders exist Note: some branching based on "is Ultra" remains _within_ certain methods and will be removed in subsequent PRs
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Preliminary `cycle_group` cleanup (no logic changes): - Extract subclasses `cycle_scalar`, `straus_lookup_table` and `straus_scalar_slice` and move to their own files - Remove methods marked `requires IsNotUltraArithmetic<Builder>` since no no-Ultra builders exist Note: some branching based on "is Ultra" remains _within_ certain methods and will be removed in subsequent PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preliminary
cycle_groupcleanup (no logic changes):cycle_scalar,straus_lookup_tableandstraus_scalar_sliceand move to their own filesrequires IsNotUltraArithmetic<Builder>since no no-Ultra builders existNote: some branching based on "is Ultra" remains within certain methods and will be removed in subsequent PRs