Skip to content

chore: Removed cache of pending transactions #19275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AztecBot merged 1 commit into from
Jan 3, 2026
Merged

chore: Removed cache of pending transactions #19275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions yarn-project/p2p/src/mem_pools/tx_pool/aztec_kv_tx_pool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ export class AztecKVTxPool

#feePayerToTxHash: AztecAsyncMultiMap<string, string>;

/** In-memory mapping of pending tx hashes to the hydrated pending tx in the pool. */
#pendingTxs: Map<string, Tx>;

/** In-memory set of txs that should not be evicted from the pool. */
#nonEvictableTxs: Set<string>;

Expand Down Expand Up @@ -124,7 +121,6 @@ export class AztecKVTxPool
this.#historicalHeaderToTxHash = store.openMultiMap('historicalHeaderToPendingTxHash');
this.#feePayerToTxHash = store.openMultiMap('feePayerToPendingTxHash');

this.#pendingTxs = new Map<string, Tx>();
this.#nonEvictableTxs = new Set<string>();

this.#archivedTxs = archive.openMap('archivedTxs');
Expand Down Expand Up @@ -576,20 +572,12 @@ export class AztecKVTxPool
* @returns The transaction, if found, 'undefined' otherwise.
*/
private async getPendingTxByHash(txHash: TxHash | string): Promise<Tx | undefined> {
let key;
if (typeof txHash === 'string') {
key = txHash;
txHash = TxHash.fromString(txHash);
} else {
key = txHash.toString();
}

if (this.#pendingTxs.has(key)) {
return this.#pendingTxs.get(key);
}
const tx = await this.getTxByHash(txHash);
if (tx) {
this.#pendingTxs.set(key, tx);
return tx;
}
return undefined;
Expand Down Expand Up @@ -664,7 +652,6 @@ export class AztecKVTxPool
// Assumes being called within a DB transaction
private async removePendingTxIndicesInDbTx(tx: Tx, txHash: string): Promise<void> {
await this.#pendingTxPriorityToHash.deleteValue(getPendingTxPriority(tx), txHash);
this.#pendingTxs.delete(txHash);
await this.#historicalHeaderToTxHash.deleteValue(
(await tx.data.constants.anchorBlockHeader.hash()).toString(),
txHash,
Expand Down
Loading