feat: add sol support and fix docs examples #19285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklppy88
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
5 times, most recently
from
b684211 to
ab356a9
Compare
sklppy88
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
from
ab356a9 to
cb909bb
Compare
critesjosh
approved these changes
Jan 5, 2026
Contributor
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
looks good, thanks for cleaning this up! approved with some minor comments
| "@oz/=../../../l1-contracts/lib/openzeppelin-contracts/contracts/", | ||
| "@aztec/=../../../l1-contracts/src/", | ||
| "@openzeppelin/contracts/=../../../l1-contracts/lib/openzeppelin-contracts/contracts/", | ||
| "@aztec-blob-lib/=../../../l1-contracts/src/mock/libraries/" |
Contributor
There was a problem hiding this comment.
this isnt being used in the docs examples contracts, i think we can remove it
| - "@aztec/stdlib" | ||
| - "@aztec/foundation" | ||
| - "@aztec/ethereum" | ||
| - "npm:viem@npm:@aztec/[email protected]" |
Contributor
There was a problem hiding this comment.
is this formatted correctly? or should it just be npm:@aztec/[email protected]?
| data: log.data, | ||
| topics: log.topics, | ||
| }); | ||
| } catch { |
Contributor
There was a problem hiding this comment.
A comment here about why the errors are ignored might be helpful.
critesjosh
approved these changes
Jan 5, 2026
Contributor
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
looks good, thanks for cleaning this up! approved with some minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs examples was broken originally, this fixes it and adds sol support