feat: add sol support and fix docs examples #19285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklppy88
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
6 times, most recently
from
ab356a9 to
cb909bb
Compare
critesjosh
approved these changes
Jan 5, 2026
Contributor
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
looks good, thanks for cleaning this up! approved with some minor comments
| - "@aztec/stdlib" | ||
| - "@aztec/foundation" | ||
| - "@aztec/ethereum" | ||
| - "npm:viem@npm:@aztec/[email protected]" |
Contributor
There was a problem hiding this comment.
is this formatted correctly? or should it just be npm:@aztec/[email protected]?
Contributor
Author
There was a problem hiding this comment.
It is, it was using the alias, but I have refactored this a bit to not have to alias
critesjosh
approved these changes
Jan 5, 2026
Contributor
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
looks good, thanks for cleaning this up! approved with some minor comments
sklppy88
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
8 times, most recently
from
ba9694b to
69ac132
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
from
69ac132 to
eca1a03
Compare
docs examples was broken originally, this fixes it and adds sol support
AztecBot
force-pushed
the
ek/feat/add-sol-support-and-fix-docs-examples
branch
from
eca1a03 to
042b6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs examples was broken originally, this fixes it and adds sol support