Skip to content

Conversation

@IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Jan 6, 2026

Mutations for gas-related fields in the tx (including gasUsedByPrivate, and Feepayer)

@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from 7b56b51 to 93eb5a8 Compare January 7, 2026 10:35
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from e8578e9 to ae09b1d Compare January 7, 2026 10:35
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from 93eb5a8 to aa96990 Compare January 7, 2026 10:43
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch 2 times, most recently from 3c26110 to d291430 Compare January 7, 2026 10:56
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from aa96990 to 3700f20 Compare January 7, 2026 10:56
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from d291430 to c282ab6 Compare January 7, 2026 15:49
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch 2 times, most recently from 3d86939 to d39d11f Compare January 8, 2026 12:48
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from c282ab6 to 40f1713 Compare January 8, 2026 12:48
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from 40f1713 to fd2d950 Compare January 8, 2026 13:04
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch 2 times, most recently from 4168739 to 6f984cd Compare January 8, 2026 13:11
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-04-feat_avm_mutations_for_accumulated_data branch from fd2d950 to 5420487 Compare January 8, 2026 13:11
@IlyasRidhuan IlyasRidhuan changed the base branch from ir/01-04-feat_avm_mutations_for_accumulated_data to graphite-base/19348 January 8, 2026 15:17
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from 6f984cd to fbabbed Compare January 8, 2026 15:49
@IlyasRidhuan IlyasRidhuan changed the base branch from graphite-base/19348 to ir/01-04-feat_avm_mutations_for_accumulated_data January 8, 2026 15:49
@IlyasRidhuan IlyasRidhuan changed the base branch from ir/01-04-feat_avm_mutations_for_accumulated_data to graphite-base/19348 January 9, 2026 13:03
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from fbabbed to ac33049 Compare January 9, 2026 13:38
@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review January 9, 2026 13:47
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from ac33049 to 193d8a7 Compare January 9, 2026 14:39
@IlyasRidhuan IlyasRidhuan changed the base branch from graphite-base/19348 to merge-train/avm January 9, 2026 14:39
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from 193d8a7 to 3faa9e2 Compare January 9, 2026 14:52
Copy link
Contributor

@sirasistant sirasistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a note on clamping vs the limit

@AztecBot
Copy link
Collaborator

AztecBot commented Jan 12, 2026

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/8797c5c9254d3cf5�8797c5c9254d3cf58;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_l1_publisher/e2e_l1_publisher.test.ts (95s) (code: 1) (\033IlyasRidhuan\033: feat(avm): gas mutations)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/a513dd5beea1c4ec�a513dd5beea1c4ec8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/gossip_network.test.ts (423s) (code: 1) group:e2e-p2p-epoch-flakes (\033IlyasRidhuan\033: feat(avm): gas mutations)

@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-05-feat_avm_gas_mutations branch from 35ef4be to a4be5dc Compare January 12, 2026 14:36
@IlyasRidhuan IlyasRidhuan merged commit ec5c6a4 into merge-train/avm Jan 13, 2026
9 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/01-05-feat_avm_gas_mutations branch January 13, 2026 09:26
@AztecBot AztecBot mentioned this pull request Jan 13, 2026
iAmMichaelConnor pushed a commit that referenced this pull request Jan 13, 2026
BEGIN_COMMIT_OVERRIDE
fix!: sha_mem.pil input_addr propagation/incrementing unconstrained
(#19522)
feat(avm): gas mutations (#19348)
fix(avm): fix asan crash during
UpdateCheckTracegenTest.HashZeroInteractions test (#19534)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants