Skip to content

fix(avm): capping rd size and fixing pipes #19420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IlyasRidhuan merged 4 commits into from
Jan 9, 2026
Merged

fix(avm): capping rd size and fixing pipes #19420

IlyasRidhuan merged 4 commits into from
Jan 9, 2026

Conversation

@IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Jan 8, 2026 •
edited
Loading

Returndata size is uncapped in TS but we have an implicit cap in CPP.

This makes the cap explicit in the cpp fuzzer and truncates the returndata from TS so that the comparisons do not trivially fail.

There's also some clean up of how reading and writing between the fuzzer and TS process works

This was referenced Jan 8, 2026
Merged
Open
@IlyasRidhuan Graphite App
Copy link
Contributor Author

IlyasRidhuan commented Jan 8, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 8, 2026
Draft
@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review January 8, 2026 13:01
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch from 1b5498a to 3f975c0 Compare January 8, 2026 13:04
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch from f92dbc1 to bdc0f68 Compare January 8, 2026 15:49
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch from bdc0f68 to 3d8bb7f Compare January 9, 2026 12:43
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch 2 times, most recently from ba81c47 to 24423bb Compare January 9, 2026 12:53
@IlyasRidhuan IlyasRidhuan merged commit ac0fe88 into merge-train/avm Jan 9, 2026
9 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/01-08-fix_avm_capping_rd_size_and_fixing_pipes branch January 9, 2026 13:37
@AztecBot AztecBot mentioned this pull request Jan 9, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2026
@AztecBot
feat: merge-train/avm (#19454)
073eb9a 
BEGIN_COMMIT_OVERRIDE
feat(avm): Migrate contract db proxy to fuzzer context (#19421)
fix(avm): capping rd size and fixing pipes (#19420)
feat(avm): mutations for accumulated data (#19347)
chore!: remove dead columns and code from avm cpp (#19442)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirasistant sirasistant sirasistant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IlyasRidhuan @sirasistant