chore: Base Fee -> Min Fee #19375
chore: Base Fee -> Min Fee #19375
Conversation
aminsammara
requested review from
IlyasRidhuan,
LHerskind,
Maddiaa0,
dbanks12,
fcarreiro,
jeanmon,
just-mitch and
sirasistant
as code owners
aminsammara
removed request for
IlyasRidhuan,
LHerskind,
Maddiaa0,
dbanks12,
fcarreiro,
jeanmon,
just-mitch and
sirasistant
aminsammara
force-pushed
the
am/change-basefee-to-minfee
branch
from
85cda13 to
7f968a4
Compare
There was a problem hiding this comment.
I don't think we ought to be modifying things in the v3 versioned docs
There was a problem hiding this comment.
I will revert all changes to versioned docs
There was a problem hiding this comment.
if we need to update the docs on that version, updating the versioned docs is fine
| | "getPXEInfo" | ||
| // Fee info | ||
| | "getCurrentBaseFees" | ||
| | "getCurrentMinFees" |
There was a problem hiding this comment.
This should be its own migration note. Can you try asking claude code to "update the changelogs"? It should just work.
There was a problem hiding this comment.
Same thing here. We can't be modifying the old versioned docs.
just-mitch
left a comment
just-mitch
left a comment
There was a problem hiding this comment.
Approved, minus the comments around docs, and I can't comment on the bb or AVM changes.
I suggest @dbanks12 has a look at least, and @critesjosh should have a look after the docs are updated.
Renamed all references to L2 base fee to min fee to better reflect their purpose: - L1 Contracts: getManaBaseFeeAt -> getManaMinFeeAt, ManaBaseFeeComponents -> ManaMinFeeComponents - Aztec.js: getCurrentBaseFees -> getCurrentMinFees - Aztec.nr: base_fee_per_l2_gas -> min_fee_per_l2_gas, base_fee_per_da_gas -> min_fee_per_da_gas - Bot config: --bot.baseFeePadding -> --bot.minFeePadding, BOT_BASE_FEE_PADDING -> BOT_MIN_FEE_PADDING Updated migration notes and changelog documentation.
aminsammara
force-pushed
the
am/change-basefee-to-minfee
branch
from
a6c4a17 to
95b9d85
Compare
|
@aminsammara was there accidentally a 4.0 nightly release? I see your renaming a bunch of those files back to 3.0. I wouldnt worry about renaming those since the nightly version will be replaced the night its merged. |
Not sure what went on there. I had them as 4.0 on local and caught it when I tried to bootstrap. If this looks fine to you, i'll merge as is now. @critesjosh |
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
one minor q but otherwise looks good
| Aztec is in full-speed development. Literally every version breaks compatibility with the previous ones. This page attempts to target errors and difficulties you might encounter when upgrading, and how to resolve them. | ||
|
|
||
| ## 3.0.0-devnet.20251212 | ||
| ## TBD |
There was a problem hiding this comment.
No not really. This was the update_changelog claude skill I believe.
|
@critesjosh it wasn't an accident- I bumped the version in the repo to 4.0.0 because we cut the v3 branch the other day. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Changed the L2 base fee to L2 min fee.
|
@just-mitch @critesjosh that version was not supposed to change from {version} to TBD. That is the changelog on the {version} side of things. I'll create a PR later to re-instate it. "TBD" should only be on |
Thanks Alejo |
Changed the L2 base fee to L2 min fee.