feat: wallet sdk improvements #19394
Merged
+698
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thunkar
requested review from
benesjan,
iAmMichaelConnor,
mverzilli and
nventuro
AztecBot
force-pushed
the
gj/wallet-sdk-improvements
branch
from
bbfdebd to
5402bc3
Compare
AztecBot
force-pushed
the
gj/wallet-sdk-improvements
branch
from
5402bc3 to
ee88629
Compare
nventuro
reviewed
Jan 8, 2026
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
I don't know enough about the crypto library to comment on that, but the readme looks lovely
Thunkar
force-pushed
the
gj/wallet-sdk-improvements
branch
from
d731a50 to
d49d305
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
force-pushed
the
gj/wallet-sdk-improvements
branch
from
c224cb0 to
87bf5d1
Compare
This PR improves the Wallet SDK so it supports private (via `MessageChannel`) and encrypted (by performing a key exchange) communications with extension wallets. It also fixes an issue with PXE not wrapping the node in a proxy, which prevented us from getting RPC stats.
AztecBot
force-pushed
the
gj/wallet-sdk-improvements
branch
from
87bf5d1 to
05251d2
Compare
nventuro
approved these changes
Jan 8, 2026
Collaborator
|
❌ Failed to cherry-pick to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Wallet SDK so it supports private (via
MessageChannel) and encrypted (by performing a key exchange) communications with extension wallets.It also fixes an issue with PXE not wrapping the node in a proxy, which prevented us from getting RPC stats.