feat: merge-train/avm #19422
Merged
feat: merge-train/avm #19422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AVM VK is fixed and available in the binary, therefore we don't need to ask the user to provide it, and we also don't need to return it after proving. I kept the `avm_get_vk` CLI option since it might be useful for inspection. Also included some cleanup and unification on the TS side. Closes [AVM-189](https://linear.app/aztec-labs/issue/AVM-189/avm-remove-vk-from-cli-parameters).
…s in cpp (#19439) To prevent crashes in worst-case scenarios
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(avm)!: dont expose/require VK (#19414)
chore(avm): params should be references
chore: defensive asserts for map/vector retrievals and optional values in cpp (#19439)
END_COMMIT_OVERRIDE