Skip to content

feat(avm): mutate global gas fees and timestamp #19500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IlyasRidhuan merged 1 commit into from
Jan 15, 2026
Merged

feat(avm): mutate global gas fees and timestamp #19500

IlyasRidhuan merged 1 commit into from
Jan 15, 2026

Conversation

@IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Jan 12, 2026 •
edited
Loading

Very very simple mutations for globals

This was referenced Jan 12, 2026
Merged
Merged
Merged
Merged
Merged
@IlyasRidhuan Graphite App
Copy link
Contributor Author

IlyasRidhuan commented Jan 12, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 12, 2026
Merged
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from de767ba to 9c68c49 Compare January 12, 2026 14:36
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_contract_instance_mutation branch from e517ae5 to 2b391cc Compare January 12, 2026 14:36
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from 9c68c49 to fe0022e Compare January 14, 2026 13:07
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_contract_instance_mutation branch from 2b391cc to 71f03ad Compare January 14, 2026 13:07
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from fe0022e to ed25916 Compare January 14, 2026 13:41
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_contract_instance_mutation branch from 71f03ad to 34a2239 Compare January 14, 2026 13:41
@IlyasRidhuan IlyasRidhuan mentioned this pull request Jan 14, 2026
Merged
@IlyasRidhuan IlyasRidhuan marked this pull request as ready for review January 14, 2026 13:43
@IlyasRidhuan IlyasRidhuan changed the title feat(avm): mutate global gas fees feat(avm): mutate global gas fees and timestamp Jan 14, 2026
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 14, 2026 •
edited
Loading

Flakey Tests

🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/df6107c51a1b2127�df6107c51a1b21278;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "committee member invalidates a block if proposer does not come through" (95s) (code: 1) group:e2e-p2p-epoch-flakes (\033IlyasRidhuan\033: feat(avm): mutate global gas fees)
\033FLAKED\033 (8;;http://ci.aztec-labs.com/ef7fff364b74a168�ef7fff364b74a1688;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_invalidate_block.parallel.test.ts "proposer invalidates multiple blocks" (604s) (code: 124) group:e2e-p2p-epoch-flakes (\033IlyasRidhuan\033: feat(avm): mutate global gas fees)

@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from ed25916 to 23929ad Compare January 14, 2026 14:44
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_contract_instance_mutation branch from 34a2239 to 09fab16 Compare January 14, 2026 14:44
sirasistant
sirasistant approved these changes Jan 15, 2026
View reviewed changes
barretenberg/cpp/src/barretenberg/avm_fuzzer/fuzzer_lib.cpp
// This is just mutating the gas values and timestamp
mutate_uint64_t(tx_data.global_variables.timestamp, rng, BASIC_UINT64_T_MUTATION_CONFIGURATION);
mutate_gas_fees(tx_data.global_variables.gas_fees, rng);
// This must be less than or equal to the tx max fees per gas
Copy link
Contributor

@sirasistant sirasistant Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo instead of min?

Copy link
Contributor Author

@IlyasRidhuan IlyasRidhuan Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i want min so that gas_fees <= max_fees_per_gas

@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_contract_instance_mutation branch from 09fab16 to f02fa60 Compare January 15, 2026 11:20
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from 23929ad to ed98aa8 Compare January 15, 2026 11:20
This was referenced Jan 15, 2026
Merged
Merged
Base automatically changed from ir/01-09-feat_avm_contract_instance_mutation to merge-train/avm January 15, 2026 12:18
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch 2 times, most recently from 5864a4d to 4221ba3 Compare January 15, 2026 14:23
@IlyasRidhuan IlyasRidhuan force-pushed the ir/01-09-feat_avm_mutate_globals branch from 4221ba3 to a21f4d8 Compare January 15, 2026 14:27
@IlyasRidhuan IlyasRidhuan merged commit 010bf28 into merge-train/avm Jan 15, 2026
9 checks passed
@IlyasRidhuan IlyasRidhuan deleted the ir/01-09-feat_avm_mutate_globals branch January 15, 2026 16:32
@AztecBot AztecBot mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirasistant sirasistant sirasistant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IlyasRidhuan @AztecBot @sirasistant