refactor: staged writes on note store #19519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
added
the
ci-no-fail-fast
…ged-writes-in-private-events
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
17914e7 to
ee88b93
Compare
…ged-writes-in-notes
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
ee88b93 to
08fb4a0
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fifth and last part of the series started with #19445.
This makes the NoteStore work based on staged writes. With this, notes (and nullifier metadata) aren't written to persistent storage until PXE decides to commit the job.
Closes F-163