feat(avm): protocol contractg mutations #19586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2026
Contributor
Author
IlyasRidhuan
force-pushed
the
ir/01-09-feat_avm_mutate_globals
branch
from
ed25916 to
23929ad
Compare
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
2 times, most recently
from
23aabe7 to
1054464
Compare
IlyasRidhuan
force-pushed
the
ir/01-09-feat_avm_mutate_globals
branch
from
23929ad to
ed98aa8
Compare
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
from
1054464 to
3bc2633
Compare
This was referenced Jan 15, 2026
IlyasRidhuan
force-pushed
the
ir/01-09-feat_avm_mutate_globals
branch
from
ed98aa8 to
5864a4d
Compare
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
from
3bc2633 to
2584a41
Compare
IlyasRidhuan
commented
Jan 15, 2026
| protected contractsDB: PublicContractsDB, | ||
| protected globalVariables: GlobalVariables, | ||
| config?: Partial<PublicSimulatorConfig>, | ||
| protected protocolContracts: ProtocolContracts = ProtocolContractsList, |
Contributor
Author
There was a problem hiding this comment.
needed to change the interface because we would otherwise force to read from the list
IlyasRidhuan
commented
Jan 15, 2026
| // MIN_FEE must be >= 1 to prevent underflow in compute_effective_gas_fees, since | ||
| // global_variables.gas_fees is hardcoded to {1, 1}. This can change once we enable | ||
| // smart mutations of global variables that maintain the invariant max_fees_per_gas >= gas_fees. | ||
| // MIN_FEE must be >= 1 to prevent underflow in compute_effective_gas_fees. |
Contributor
Author
There was a problem hiding this comment.
This comment was missed when we mutated hte global variables in an earlier pr
IlyasRidhuan
commented
Jan 15, 2026
|
|
||
| namespace { | ||
|
|
||
| void update_enqueued_calls_for_protocol_contract(Tx& tx, |
Contributor
Author
There was a problem hiding this comment.
this is a bit of a code-smell, but we need to update the addresses used in the enqueued calls whenever we modify the protocol contracts and we would have potentially invalidated addresses that are referenced by enqueued calls
IlyasRidhuan
commented
Jan 15, 2026
| // For protocol contracts, also add instances keyed by canonical address (1-11). | ||
| // This is needed because protocol contracts are looked up by canonical address, | ||
| // but the derived address in protocol_contracts.derived_addresses maps to the actual instance. | ||
| for (size_t i = 0; i < tx_data.protocol_contracts.derived_addresses.size(); ++i) { |
Contributor
Author
There was a problem hiding this comment.
This is so that when we look up the protocol contracts we can retrieve the instance
IlyasRidhuan
commented
Jan 15, 2026
| break; | ||
| } | ||
|
|
||
| // Clear any protocol contract derived addresses that reference addresses no longer in the contract set. |
Contributor
Author
There was a problem hiding this comment.
This is pretty lazy, but i was running into some issues with calling stale contract addresses. I'll investigate a cleaner way to ensure we dont need a clean up step after mutations.
IlyasRidhuan
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
IlyasRidhuan
changed the base branch from
ir/01-09-feat_avm_mutate_globals
to
graphite-base/19586
IlyasRidhuan
force-pushed
the
graphite-base/19586
branch
from
5864a4d to
a21f4d8
Compare
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
from
2584a41 to
8b90735
Compare
IlyasRidhuan
changed the base branch from
graphite-base/19586
to
ir/01-09-feat_avm_mutate_globals
Base automatically changed from
ir/01-09-feat_avm_mutate_globals
to
merge-train/avm
January 15, 2026 16:32
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
2 times, most recently
from
4c7af27 to
2c157cb
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
sirasistant
reviewed
Jan 16, 2026
IlyasRidhuan
force-pushed
the
ir/01-13-feat_avm_protocol_contract_mutations
branch
from
2c157cb to
16c9a69
Compare
sirasistant
approved these changes
Jan 16, 2026
IlyasRidhuan
deleted the
ir/01-13-feat_avm_protocol_contract_mutations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol contract mutations turned out to be much more complex. Might've been easier to implement a hardcoded set.
We need to ensure we re-validate the enqueued calls whenever we mutate the protocol contracts since we could have invalidated some addresses.
Note: The TS simulation required a change to match the cpp simulator