refactor: moving BenchmarkedNode to e2e
#19696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
changed the title
BenchmarkedNode to e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing #19689 I realized that the roundtrip regression test I implement last week was not getting triggered.
It turns out that this is because we used the
BenchmarkedNodeonly during contract simulation but not during the whole flow of building a tx and the optimizations in that PR were done when fetching sibling paths for kernels.Hence the best way to fix this seemed to just make
BenchmarkedNodetrack everything. If this is done then we can just pass in aBenchmarkedNodeto the constructor ofPXEand makePXEunaware of benchmarking.This ultimately seems like a good design principle so I decided to move the functionality to
e2eand I update the relevant test harnesses that require the node benchmarking info.