refactor: minor naming cleanups #19685
Open
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
01-16-refactor_renaming_proxiednode_as_benchmarkednode
branch
from
a5865fe to
837cdd9
Compare
benesjan
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
force-pushed
the
01-16-refactor_renaming_proxiednode_as_benchmarkednode
branch
from
837cdd9 to
56e6ac9
Compare
In this PR I rename `ProxiedNode` as `BenchmarkedNode` because `ProxiedNode` name was just bad (originally discussed [here](#19291 (comment))) and I rename `build_nullifier_read_request_hints.ts` to reflect the name of the class it contains.
AztecBot
force-pushed
the
01-16-refactor_renaming_proxiednode_as_benchmarkednode
branch
from
56e6ac9 to
e7c2d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I rename
ProxiedNodeasBenchmarkedNodebecauseProxiedNodename was just bad (originally discussed here) and I renamebuild_nullifier_read_request_hints.tsto reflect the name of the class it contains.