fix(ethereum): use proposal's pendingThrough timestamp for voting power #19856
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vote method was using getPower() which checks powerAt(now.timestamp), but the contract requires timestamps to be strictly less than block.timestamp. This caused votes without explicit amounts to fail with NotInPast error. Added getPowerForProposal() that correctly uses the proposal's pendingThrough timestamp (creation + votingDelay) to match the contract's voting logic.
just-mitch
approved these changes
Jan 23, 2026
Collaborator
|
Thanks! |
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 23, 2026
…er (#19856) ## Summary - Fixed a bug in the governance CLI where voting without an explicit `--vote-amount` would fail with `Governance__CheckpointedUintLib__NotInPast` error - Added `getPowerForProposal(proposalId)` method that correctly uses the proposal's `pendingThrough` timestamp (creation + votingDelay) to determine voting power - Updated `vote()` method to use `getPowerForProposal()` instead of the broken `getPower()` which was incorrectly using the current block timestamp ## Background The governance contract checks voting power at `pendingThrough` timestamp (when proposal transitions from Pending to Active). The CLI's `getPower()` method was calling `powerAt(now.timestamp)` which always failed because the contract requires `_time < block.timestamp` (strictly less than). ## Test plan - [x] Tested on local Anvil network with full governance flow (deposit → propose → vote → execute) - [x] Verified voting works without explicit `--vote-amount` flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--vote-amountwould fail withGovernance__CheckpointedUintLib__NotInPasterrorgetPowerForProposal(proposalId)method that correctly uses the proposal'spendingThroughtimestamp (creation + votingDelay) to determine voting powervote()method to usegetPowerForProposal()instead of the brokengetPower()which was incorrectly using the current block timestampBackground
The governance contract checks voting power at
pendingThroughtimestamp (when proposal transitions from Pending to Active). The CLI'sgetPower()method was callingpowerAt(now.timestamp)which always failed because the contract requires_time < block.timestamp(strictly less than).Test plan
--vote-amountflag