fix: pass --watch flag to swc in tsc.sh watch mode #19912
Merged
+82
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The swc commands in watch mode were constructed inline without the --watch flag, causing JS files to not be rebuilt when source files changed. Fixed by extracting swc_args and using it consistently across all swc invocations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ludamad
approved these changes
Jan 23, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
yarn build -wwould check for type errors but not emit JS changes--watchflagswc_argsvariable and use it consistently across all swc invocationsTest plan
./scripts/tsc.test.sh- all 28 tests pass including new watch mode testyarn build -wfrom yarn-project root, modify a file, verify JS is rebuilt🤖 Generated with Claude Code