-
Notifications
You must be signed in to change notification settings - Fork 18
Throttling Tx Ingress #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PhilWindle
wants to merge
1
commit into
main
Choose a base branch
from
pw/tx-ingress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Intro | ||
|
|
||
| For the first release of the network where we permit transactions, we want to retain some ability to moderate the rate of transaction ingress. This is difficult with a decentralised system and no solution can be perfect. | ||
|
|
||
| But assuming the majority of nodes respect default implementation and behaviour there is some control that can be achieved. | ||
|
|
||
| ## Current Architecture | ||
|
|
||
| Today, when an RPC node receives a transaction, after successful validation it immediately broadcasts the transaction onto the P2P network. The issue here is that we could end up with a flood of transactions and nodes could be overwhelmed. | ||
|
|
||
| The knock on effect here could be nodes can't keep up with verifying ClientIVC proofs and/or transactions could be dropped causing diverging mempools. | ||
|
|
||
| ## Proposed Changes | ||
|
|
||
| The only way to moderate the flow of transactions around the network is to control their ingress at source. Once a tx is being propagated it can't be impeded, to do so would exacerbate the problem of divergent mempools. | ||
|
|
||
| So the proposed changes are to track the average rate of transaction delivery at the p2p network, say over the last `N` seconds where `N` is configurable. If this goes beyond a configured threshold, transactions will be rejected at the RPC layer until it reduces. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand what's tracked exactly here. By transaction delivery, does it mean the number of txs received via JSON RPC API that this node injected into the p2p network? Or all txs that were broadcasted, including the ones received via p2p?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would see it as ('Transactions I received over the P2P network' + 'Transactions I introduced to the P2P network' / 'N'). My observed TPS of the network.