Skip to content

Conversation

@flkasper
Copy link
Contributor

The temporaryUrl method is defined in the \League\Flysystem\UrlGeneration\TemporaryUrlGenerator interface and may throw an \League\Flysystem\UnableToGenerateTemporaryUrl exception.

This change ensures that only this exceptions are thrown.

  • The \InvalidArgumentException was replaced.
  • In the \AzureOss\Storage\Blob\BlobClient::generateSasUri method, an \Exception::__construct exception is thrown if an authentication method other than \AzureOss\Storage\Common\Auth\StorageSharedKeyCredential is used, e.g., authentication with \AzureOss\Storage\Common\Auth\AccessToken.
    This exception is then caught and wrapped in the expected one.

@flkasper flkasper marked this pull request as ready for review November 26, 2025 22:43
@brecht-vermeersch brecht-vermeersch self-assigned this Nov 27, 2025
@brecht-vermeersch brecht-vermeersch merged commit 667d77c into Azure-OSS:main Nov 27, 2025
8 checks passed
@brecht-vermeersch
Copy link
Member

Thanks for the changes!

@flkasper flkasper deleted the fix/temporaryUrl-exception branch November 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants