Fix throwing exception typ of temporaryUrl #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
temporaryUrlmethod is defined in the\League\Flysystem\UrlGeneration\TemporaryUrlGeneratorinterface and may throw an\League\Flysystem\UnableToGenerateTemporaryUrlexception.This change ensures that only this exceptions are thrown.
\InvalidArgumentExceptionwas replaced.\AzureOss\Storage\Blob\BlobClient::generateSasUrimethod, an\Exception::__constructexception is thrown if an authentication method other than\AzureOss\Storage\Common\Auth\StorageSharedKeyCredentialis used, e.g., authentication with\AzureOss\Storage\Common\Auth\AccessToken.This exception is then caught and wrapped in the expected one.