Closed
Conversation
There was a problem hiding this comment.
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:76
- The variable
openai_deployment_nameis declared twice. The first declaration should be removed to avoid redundancy.
openai_deployment_name = "gpt-35-turbo"
labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:159
- [nitpick] The error message "Deployment '{deployment_name}' failed" could be more descriptive to help diagnose the issue.
output = utils.run(f"az deployment group create --name {deployment_name} --resource-group {resource_group_name} --template-file main.bicep --parameters params.json", f"Deployment '{deployment_name}' succeeded", f"Deployment '{deployment_name}' failed")
labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:182
- [nitpick] The error message "Failed to retrieve deployment: {deployment_name}" could be more descriptive to help diagnose the issue.
output = utils.run(f"az deployment group show --name {deployment_name} -g {resource_group_name}", f"Retrieved deployment: {deployment_name}", f"Failed to retrieve deployment: {deployment_name}")
|
|
||
| for cell in notebook_content.get('cells', []): | ||
| if cell.get('cell_type') == 'code' and cell.get('outputs'): | ||
| print(f"The notebook {filename} has outputs stored.", file=sys.stderr) |
There was a problem hiding this comment.
The variable 'filename' should be 'file'.
Suggested change
| print(f"The notebook {filename} has outputs stored.", file=sys.stderr) | |
| print(f"The notebook {file} has outputs stored.", file=sys.stderr) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
git clone [repo-address] cd [repo-name] git checkout [branch-name] npm installWhat to Check
Verify that the following are valid:
Other Information