Skip to content

Deprecated labs#88

Closed
vieiraae wants to merge 4 commits intomainfrom
deprecated-labs
Closed

Deprecated labs#88
vieiraae wants to merge 4 commits intomainfrom
deprecated-labs

Conversation

@vieiraae
Copy link
Contributor

Purpose

  • the goal is to move deprecated labs to the deprecated folder

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid:

  • ...

Other Information

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:76

  • The variable openai_deployment_name is declared twice. The first declaration should be removed to avoid redundancy.
openai_deployment_name = "gpt-35-turbo"

labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:159

  • [nitpick] The error message "Deployment '{deployment_name}' failed" could be more descriptive to help diagnose the issue.
output = utils.run(f"az deployment group create --name {deployment_name} --resource-group {resource_group_name} --template-file main.bicep --parameters params.json", f"Deployment '{deployment_name}' succeeded", f"Deployment '{deployment_name}' failed")

labs/backend-pool-load-balancing/backend-pool-load-balancing.ipynb:182

  • [nitpick] The error message "Failed to retrieve deployment: {deployment_name}" could be more descriptive to help diagnose the issue.
output = utils.run(f"az deployment group show --name {deployment_name} -g {resource_group_name}", f"Retrieved deployment: {deployment_name}", f"Failed to retrieve deployment: {deployment_name}")


for cell in notebook_content.get('cells', []):
if cell.get('cell_type') == 'code' and cell.get('outputs'):
print(f"The notebook {filename} has outputs stored.", file=sys.stderr)
Copy link

Copilot AI Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'filename' should be 'file'.

Suggested change
print(f"The notebook {filename} has outputs stored.", file=sys.stderr)
print(f"The notebook {file} has outputs stored.", file=sys.stderr)

Copilot uses AI. Check for mistakes.
@vieiraae vieiraae closed this Jan 14, 2025
@vieiraae vieiraae deleted the deprecated-labs branch January 14, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants