Skip to content

Fix missing priority & weight properties#93

Merged
vieiraae merged 1 commit intomainfrom
fix-load-balancing-priority-weight
Jan 15, 2025
Merged

Fix missing priority & weight properties#93
vieiraae merged 1 commit intomainfrom
fix-load-balancing-priority-weight

Conversation

@simonkurtz-MSFT
Copy link
Member

Purpose

  • Adds priority & weight properties back to the backend pool after I inadvertently dropped them in this commit.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Run the backend loadbalancer lab.

What to Check

Verify that the following are valid:

  • Observe a distribution of all requests to priority 1 before falling back to a somewhat equal distribution across two priority 2 AOAI backends.

Other Information

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • modules/apim/v1/openai-api.bicep: Language not supported
  • modules/cognitive-services/v1/openai.bicep: Language not supported

@vieiraae vieiraae merged commit cebe490 into main Jan 15, 2025
4 checks passed
@vieiraae vieiraae deleted the fix-load-balancing-priority-weight branch January 15, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants